Check if plugin consumes v8 symbols #2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petekanev
force-pushed
the
pete/plugin-check-deps-v8
branch
from
bd0c628 to
5d29e0a
Compare
petekanev
force-pushed
the
pete/plugin-check-deps-v8
branch
from
5d29e0a to
c00dd98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces additional logic on beforePrepare in android builds to execute a node script that checks for dependencies consuming the public v8 API.
This is necessary in order to decide whether or not the optimized runtime package (stripped v8 symbols) should be used in the resulting APK.
@NativeScript/android-runtime